dev-vcs/gitlab-shell-8.4.1 installs some executables without x-bit
After upgrading to gitlabhq-11.5.1 and as a dependency to gitlab-shell-8.4.1 we got the error
Failed to exec("/var/lib/gitlab-shell/bin/gitlab-shell-ruby"): permission denied
on a git pull
for example.
I checked the permissions in /var/lib/gitlab-shell/bin/
and three more were missing the x-bit:
root@theogit gitlab-shell/bin<13:35# ll
total 27M
drwxr-xr-x 2 root root 4.0K Nov 30 13:18 ./
drwxr-xr-x 8 git root 4.0K Nov 30 13:04 ../
-rwxr-xr-x 1 root root 714 Nov 30 13:04 authorized_keys*
-rwxr-xr-x 1 root root 794 Nov 30 13:04 check*
-rwxr-xr-x 1 root root 344 Nov 30 13:04 compile*
-rwxr-xr-x 1 root root 1.4K Nov 30 13:04 create-hooks*
-rwxr-xr-x 1 root root 8.4M Nov 30 13:04 gitaly-receive-pack*
-rw-r--r-- 1 root root 8.4M Nov 30 13:04 gitaly-upload-archive
-rwxr-xr-x 1 root root 8.4M Nov 30 13:04 gitaly-upload-pack*
-rwxr-xr-x 1 root root 561 Nov 30 13:04 gitlab-keys*
-rwxr-xr-x 1 root root 1.8M Nov 30 13:04 gitlab-shell*
-rwxr-xr-x 1 root root 1.5K Nov 30 13:04 gitlab-shell-authorized-keys-check*
-rw-r--r-- 1 root root 1.4K Nov 30 13:04 gitlab-shell-authorized-principals-check
-rw-r--r-- 1 root root 628 Nov 30 13:04 gitlab-shell-ruby
-rwxr-xr-x 1 root root 636 Nov 30 13:04 install*
-rw-r--r-- 1 root root 267 Nov 30 13:04 test-logger
After
chmod 755 gitaly-upload-archive gitlab-shell-authorized-principals-check gitlab-shell-ruby test-logger
the error was gone.
I checked the gitlab-shell-8.4.1.ebuild and found in the all_ruby_install()
function:
for bin in authorized_keys check compile create-hooks gitaly-receive-pack gitaly-upload-pack gitlab-keys gitlab-shell gitlab-shell-authorized-keys-check install ; do
fperms 0755 ${DEST_DIR}/bin/${bin} || die
done
(this is unchanged towards gitlab-shell-8.3.3.ebuild). Shouldn't all the files in ${DEST_DIR}/bin/
set to 0755 permissions?