dev-vcs/gitlab-gitaly-1.34.0 installs some executables without x-bit
On my first push I got the error:
remote: /var/lib/gitlab-gitaly/ruby/git-hooks/pre-receive: line 6: /var/lib/gitlab-gitaly/ruby/git-hooks/../gitlab-shell/hooks/pre-receive: Permission denied
remote: /var/lib/gitlab-gitaly/ruby/git-hooks/pre-receive: line 6: exec: /var/lib/gitlab-gitaly/ruby/git-hooks/../gitlab-shell/hooks/pre-receive: cannot execute: Permission denied
This is caused by the missing x-bit here:
cd /var/lib/gitlab-gitaly/ruby/gitlab-shell/hooks/
ll
total 20K
drwxr-xr-x 2 root root 4.0K Apr 29 13:38 ./
drwxr-xr-x 6 root root 4.0K Apr 29 13:38 ../
-rw-r--r-- 1 root root 587 Apr 29 13:38 post-receive
-rw-r--r-- 1 root root 1.1K Apr 29 13:38 pre-receive
-rw-r--r-- 1 root root 398 Apr 29 13:38 update
With version 1.34.0 of gitaly the hooks path changed from
/var/lib/gitlab-gitaly/ruby/vendor/gitlab-shell/hooks
to
/var/lib/gitlab-gitaly/ruby/gitlab-shell/hooks
but the ebuild still tries to set the permissions on the old path:
for hook in $(find_files /var/lib/gitlab-gitaly/ruby/vendor/gitlab-shell/hooks) ; do
fperms 0755 $hook
done
This has to be corrected to:
for hook in $(find_files /var/lib/gitlab-gitaly/ruby/gitlab-shell/hooks) ; do
fperms 0755 $hook
done